Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfc: distributed coordinator #1078

Merged
merged 1 commit into from
Feb 25, 2025
Merged

rfc: distributed coordinator #1078

merged 1 commit into from
Feb 25, 2025

Conversation

burgerdev
Copy link
Contributor

No description provided.

@burgerdev burgerdev added the no changelog PRs not listed in the release notes label Dec 17, 2024
3u13r
3u13r requested changes Dec 18, 2024
View reviewed changes
thomasten
thomasten reviewed Feb 7, 2025
View reviewed changes
burgerdev
burgerdev commented Feb 11, 2025
View reviewed changes
@burgerdev burgerdev marked this pull request as ready for review February 11, 2025 15:53
msanft
msanft reviewed Feb 11, 2025
View reviewed changes
msanft
msanft approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up so thoroughly and well-explained!

To the best of my (arguably limited) knowledge on this part of Contrast, this looks good.

thomasten
thomasten approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks solid to me! (modulo my incomplete knowledge on some Contrast details)
nit: there are still some mentions of RFC009 in the text

3u13r
3u13r approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgerdev @3u13r
rfc: distributed coordinator
53082c3 
Co-authored-by: Thomas Tendyck <[email protected]>

Co-authored-by: 3u13r <[email protected]>
@burgerdev burgerdev merged commit 4b60024 into main Feb 25, 2025
7 checks passed
@burgerdev burgerdev deleted the rfc/009 branch February 25, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3u13r 3u13r 3u13r approved these changes

@katexochen katexochen katexochen approved these changes

@thomasten thomasten thomasten approved these changes

@msanft msanft msanft approved these changes

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@burgerdev @3u13r @katexochen @thomasten @msanft